fix(android): merge tombstone and Native SDK event message.#5095
Merged
supervacuus merged 1 commit intomainfrom Feb 12, 2026
Merged
Conversation
supervacuus
requested review from
adinauer,
lcian,
markushi and
romtsn
as code owners
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fcec2f2 | 328.91 ms | 387.75 ms | 58.84 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| 23d6b12 | 354.10 ms | 408.38 ms | 54.28 ms |
| 27d7cf8 | 314.17 ms | 347.00 ms | 32.83 ms |
| bbc35bb | 298.53 ms | 372.17 ms | 73.64 ms |
| d15471f | 342.08 ms | 415.44 ms | 73.35 ms |
| 8687935 | 294.00 ms | 304.02 ms | 10.02 ms |
| d364ace | 411.72 ms | 430.81 ms | 19.10 ms |
| ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 23d6b12 | 1.58 MiB | 2.10 MiB | 532.31 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 8687935 | 1.58 MiB | 2.19 MiB | 619.17 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
romtsn
approved these changes
Feb 11, 2026
supervacuus
deleted the
fix/android/merge_tombstone_native_sdk_event_message
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
When merging tombstone and Native SDK events, we assume the message from the Native SDK. However, in most cases, this property will be empty from the Native SDK, whereas we explicitly construct a message from the tombstone that closely matches what debuggerd would print in logcat. This PR uses the tombstone message if the native envelope doesn't provide one.
💡 Motivation and Context
Better crash information.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.